Feature/remove session context #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
force-pushed
the
feature/remove-session-context
branch
from
45364be to
89eb0a1
Compare
…rnment. Also since adding the docker ignore, we can just copy in the entire directory that remains.
andygrove
reviewed
Oct 19, 2024
| ) -> Iterable[pa.RecordBatch]: | ||
| start_time = time.time() | ||
| plan = datafusion_ray.deserialize_execution_plan(plan_bytes) | ||
| # plan = datafusion_ray.deserialize_execution_plan(plan_bytes) |
There was a problem hiding this comment.
nit: can we remove this line now?
andygrove
reviewed
Oct 19, 2024
Comment on lines
+92
to
+96
| // println!("Planning {}", sql); | ||
| // let df = wait_for_future(py, self.ctx.sql(sql))?; | ||
| // let py_df = self.run_sql(sql, py)?; | ||
| // let py_plan = py_df.call_method0(py, "execution_plan")?; | ||
| // let py_plan = py_plan.bind(py); |
There was a problem hiding this comment.
can we remove this commented out code?
andygrove
approved these changes
Oct 19, 2024
|
Sorry I missed those commented lines. I’m out for the weekend so I’ll push the edits Monday. |
I think is fine to fix those in a follow up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
datafusion-pythonSessionContext from being owned byContextindatafusion-ray. This allows the user to use all of the features already existing indatafusion-python.I have tested it against the example
tips.py